v0.2 wip #72
v0.2 wip #72
Conversation
| */ | ||
| const edit = async (file, contents) => { | ||
| const updatedPromise = new Promise((resolve) => { | ||
| // FIXME? |
There was a problem hiding this comment.
fix what? that the code below doesn't include the filename in the resolve check anymore? that could lead to false positives if there are multiple edits in parallel
There was a problem hiding this comment.
Yes, that's it.
As a matter of fact, this doesn't affect currently existing tests and, even though I don't remember, there was a reason I removed it.
My take is go with this version until we actually have the need because of some new tests... Which might very well be never, since focus will now shift on Svelte 5.
There was a problem hiding this comment.
didn't check all the tests for soundness and the syntax/DSL for defining tests takes a bit to get used to but +1 to it being less verbose than classic playwright tests.
github matrix and package.json look ok.
needs some changeset files to describe the changes done to the package (dropped support for nollup, node12 etcpp)
Co-authored-by: Ben McCann <[email protected]>
rixo
force-pushed
the
v0.2-wip
branch
2 times, most recently
from
4ac617a
to
22769e8
Compare
Indeed... I've removed them.
I gave it a shot, but it's not playing well with pnpm and the current config so, yeah, I'm leaving out of this MR. |
No description provided.